Important! Template update for nf-core/tools v2.13 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edmundmiller
force-pushed
the
nf-core-template-merge-2.13
branch
from
7543388
to
1b7c149
Compare
edmundmiller
force-pushed
the
nf-core-template-merge-2.13
branch
from
1b7c149
to
ef19238
Compare
Following the template
edmundmiller
force-pushed
the
nf-core-template-merge-2.13
branch
from
ef19238
to
c6176ef
Compare
CarsonJM
reviewed
Feb 28, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| aligner: ["bismark", "bismark_hisat", "bwameth"] | |||
| steps: | |||
| - name: Launch workflow via tower | |||
| uses: seqeralabs/action-tower-launch@v2 | |||
| uses: seqeralabs/action-tower-launch@922e5c8d5ac4e918107ec311d2ebbd65e5982b3d # v2 | |||
There was a problem hiding this comment.
Schrödinger's action 🤷🏻♂️
| .groupTuple() | ||
| .map { | ||
| meta, fastq -> | ||
| def meta_clone = meta.clone() |
There was a problem hiding this comment.
Can you not just replace the id?
There was a problem hiding this comment.
I don't know, honestly. I think there's a section in the advanced training on this. @sateeshperi just updated it in #381.
As I said above, I think we need to turn this into a subworkflow.
There was a problem hiding this comment.
that's right - see bytesize by Rob Syme about workflow safety & immutable objects tl;dr - never modify meta maps in place
CarsonJM
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
2.13of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the
nf-core-template-merge-2.13branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.
For more information about this release of nf-core/tools, please see the
v2.13release page.